feat: Warn or prevent scheduling interval faster than data timeframe (#396)#398
Merged
MDUYN merged 1 commit intoMar 19, 2026
Conversation
…han data timeframe (#396) - Add validation in TradingStrategy.__init__ that compares the strategy's scheduling interval (time_unit * interval) against the smallest OHLCV data source timeframe. Raises OperationalException with a descriptive message if the interval is too fast. - Add 7 tests in tests/app/test_strategy_interval_validation.py covering all edge cases (faster, equal, slower, multiple sources, no sources, non-OHLCV sources, error message content). - Fix test strategies in test_data_completeness.py that had invalid 1-minute intervals with 1-day OHLCV data.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #396
Raises
OperationalExceptionduringTradingStrategy.__init__when the strategy's scheduling interval is faster than the smallest OHLCV data source timeframe.Changes
investing_algorithm_framework/app/strategy.py— Added validation that computes the scheduling interval (time_unit.amount_of_minutes * interval) and compares it against the smallest OHLCV data source timeframe. Raises a descriptiveOperationalExceptionif the interval is too fast.tests/app/test_strategy_interval_validation.py(new) — 7 test cases covering: raises on too-fast interval, accepts matching/slower intervals, validates against smallest OHLCV source, skips when no OHLCV sources, skips non-OHLCV sources, and checks the error message.tests/app/test_data_completeness.py— Fixed test strategies that had invalid 1-minute intervals with 1-day OHLCV data (updated to DAY).Example error message
Tests
All 161 app tests pass (
poetry run pytest tests/app/ -v).